Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra semi-colon from step.css also #77

Closed

Conversation

sahi1422
Copy link
Contributor

@sahi1422 sahi1422 commented Dec 17, 2021

@jlukic @levithomason , I forgot to remove the semi-colon from the step.css

#76

@ajohnston1219
Copy link

Is there a reason this is still open? I can confirm this is the same exact edit I have to do to get it working with webpack 5.

@R3DST0RM
Copy link

Are there any updates on why this isn't merged yet?

@guslen
Copy link

guslen commented Sep 15, 2022

@fniessink or maybe @peacekeeper or @sahi1422 ?
Also, a version bump would be awesome, @sahi1422

@guslen
Copy link

guslen commented Sep 16, 2022

@jlukic will you merge this? Also, a version bump would be excellent. 😄

@guslen
Copy link

guslen commented Sep 20, 2022

@peacekeeper, do you know who can merge this pull request?

@peacekeeper
Copy link

Sorry I don't know.. I also wish this could be merged.

@guslen
Copy link

guslen commented Sep 20, 2022

@peacekeeper

Sorry I don't know.. I also wish this could be merged.

I sent an email to info@semantic-ui.com with this content:
Subject:

Who can merge PR in Semantic css

Content:

Hi,
We need a merge and a version bump for semantic-ui-css. jlucik @jlukic doesn't seem to react even after tagging him. I don't know who is in charge of the repo.
this is the PR in question #77 (comment)

Thank you for the help.

Best regards,
Gustav Lennart Voigt

@jlukic
Copy link
Member

jlukic commented Sep 20, 2022

These repos are automatically generated from the main Semantic UI repo with a release bot.

You will need to make any PR requests off the main repo src/ folder if there's a typo.

You can find the correct file here
https://github.com/Semantic-Org/Semantic-UI/blob/master/src/themes/default/elements/step.overrides#L5

@jlukic
Copy link
Member

jlukic commented Oct 6, 2022

I've gone ahead and run the release bot to publish the changes from the main repo @sahi1422

@jlukic jlukic closed this Oct 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants