remove extra semi colon to fix webpack 5 build issue #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Same issue as discussed in Semantic-Org/Semantic-UI-CSS#75 and partially fixed in Semantic-Org/Semantic-UI-CSS#76
|
Thanks for the PR. However this CSS repo gets automatically updated on new releases from the main repo only. |
Closed
|
Hey, this is still not fixed and I have to still manually remove the semi-colon. Can someone review this? |
cynner
approved these changes
Sep 4, 2022
|
Looks like the PR for the main repo has been merged. When can we expect this issue to be fixed in this repo? |
|
LucienLeMagicien
added a commit
to LucienLeMagicien/Semantic-UI
that referenced
this pull request
Sep 22, 2022
Related issues: Semantic-Org#7073 fomantic/Fomantic-UI-CSS#12 Semantic-Org/Semantic-UI-CSS#75 Semantic-Org/Semantic-UI-CSS#76 Semantic-Org/Semantic-UI-CSS#77 Semantic-Org/Semantic-UI-CSS#78 fomantic/Fomantic-UI-CSS#12 Semantic-Org/Semantic-UI-LESS#77 See also: https://www.npmjs.com/package/@semantic-ui-react/css-patch
|
Fixed in latest 2.9.0 release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same issue as discussed in Semantic-Org/Semantic-UI-CSS#75 and partially fixed in Semantic-Org/Semantic-UI-CSS#76