Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code snippet #201

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

aureliosaraiva
Copy link
Collaborator

@aureliosaraiva aureliosaraiva commented Aug 1, 2017

This is a proposal to change the way we get the code snippet in the documentation.

What this solves?

  • Resolving a snippet problem is not valid
  • Solve the problem of updating the example and do not remember to update the snippet
  • Possibility of catching snippet of controller, component, route

This project also use it.

https://github.com/miguelcobain/ember-paper
https://github.com/ef4/ember-code-snippet

If they agree, I can replicate it for all the documentation.

Copy link
Contributor

@khornberg khornberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this method and use it in other projects.
I particularly like that the code which is used to produced the view is then available to see.

@@ -17,9 +18,6 @@ module.exports = function(defaults) {
behave. You most likely want to be modifying `./index.js` or app's build file
*/

// Import Highlight.js
app.import(app.bowerDirectory + "/highlightjs/highlight.pack.min.js");

app.import(app.bowerDirectory + "/highlightjs/styles/github-gist.css");
app.import(app.bowerDirectory + "/highlightjs/styles/hybrid.css");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If highlightjs is gone are these necessary?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@championswimmer
Copy link
Collaborator

looks like a good way to do this

Copy link
Contributor

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please Resolve your conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants