Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dropdown):make active dropdown item scroll into view on open #1465

Conversation

mchirkin
Copy link
Contributor

Fix #1388

@codecov-io
Copy link

codecov-io commented Mar 15, 2017

Codecov Report

Merging #1465 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1465      +/-   ##
==========================================
+ Coverage   99.74%   99.74%   +<.01%     
==========================================
  Files         141      141              
  Lines        2363     2369       +6     
==========================================
+ Hits         2357     2363       +6     
  Misses          6        6
Impacted Files Coverage Δ
src/modules/Dropdown/Dropdown.js 100% <100%> (ø)
src/modules/Search/Search.js 100% <0%> (ø)
src/elements/Input/Input.js 100% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d05722...11476af. Read the comment docs.

@levithomason
Copy link
Member

Looks great, thanks! I'll push a test for this and merge.

@levithomason levithomason merged commit 67c737f into Semantic-Org:master Mar 16, 2017
@levithomason
Copy link
Member

Released in semantic-ui-react@0.67.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants