Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active Dropdown item should be scrolled into view on open #1388

Closed
levithomason opened this issue Feb 26, 2017 · 0 comments
Closed

Active Dropdown item should be scrolled into view on open #1388

levithomason opened this issue Feb 26, 2017 · 0 comments

Comments

@levithomason
Copy link
Member

levithomason commented Feb 26, 2017

Steps

  1. Set selectOnBlur={false}
  2. Make an item active.
  3. Scroll the dropdown so it is out of view.
  4. Close the dropdown.
  5. Open the Dropdown.

Actual

The Dropdown does not show the active item because it persists its scroll position, so the active item is still out of view.

Expected

Opening the dropdown should always show the active item. Otherwise, users are confused by what they see.

Fix

There is already a method to scroll the active item into view. We simply need to call it on open.

Version

Version 0.66.0

mchirkin added a commit to mchirkin/Semantic-UI-React that referenced this issue Mar 15, 2017
levithomason pushed a commit that referenced this issue Mar 16, 2017
* fix:make active dropdown item visible into view(#1388)

* fix:check this.ref, menu, item in scrollSelectedItemIntoView method

* test(Dropdown): scroll item into view on open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant