Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Embed): add iframe shorthand #1810

Merged
merged 4 commits into from
Jul 28, 2017
Merged

feat(Embed): add iframe shorthand #1810

merged 4 commits into from
Jul 28, 2017

Conversation

layershifter
Copy link
Member

Fixes #1804.

@layershifter
Copy link
Member Author

@levithomason There is single failing test:

iframe shorthand prop (common)
✖ renders a iframe from elements

I can't fix it, looks like a problem with default value src, but nothing changes if I define it in shorthandDefaultProps. BTW, we can simply pick the strictAssert feature from #1795.

@layershifter
Copy link
Member Author

Requires #1845.

@codecov-io
Copy link

codecov-io commented Jul 22, 2017

Codecov Report

Merging #1810 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1810      +/-   ##
==========================================
+ Coverage   99.75%   99.75%   +<.01%     
==========================================
  Files         145      145              
  Lines        2477     2478       +1     
==========================================
+ Hits         2471     2472       +1     
  Misses          6        6
Impacted Files Coverage Δ
src/modules/Embed/Embed.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02daf0f...2d1366f. Read the comment docs.

Copy link
Member Author

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unblocked, ready for review 👍

@levithomason levithomason merged commit ca139f5 into master Jul 28, 2017
@levithomason levithomason deleted the feat/embed-iframe branch July 28, 2017 16:36
@levithomason
Copy link
Member

👍

@levithomason
Copy link
Member

Released in semantic-ui-react@0.71.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants