tests(shorthand): allow non-strict assert #1845
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 9, 2017
Codecov Report
@@ Coverage Diff @@
## master #1845 +/- ##
=========================================
Coverage ? 99.75%
=========================================
Files ? 145
Lines ? 2477
Branches ? 0
=========================================
Hits ? 2471
Misses ? 6
Partials ? 0
Continue to review full report at Codecov.
|
| @@ -63,6 +63,7 @@ describe('Input', () => { | |||
| common.implementsHTMLInputProp(Input, { | |||
| alwaysPresent: true, | |||
| shorthandDefaultProps: { type: 'text' }, | |||
| strictAssert: false, | |||
There was a problem hiding this comment.
How about assertExactMatch or similar? It is not clear what is being strictly asserted.
There was a problem hiding this comment.
Yep, I like your suggestion, will change 👍
…b.com/Semantic-Org/Semantic-UI-React into tests/shorthand-strict # Conflicts: # test/specs/commonTests/implementsShorthandProp.js
layershifter
force-pushed
the
tests/shorthand-strict
branch
from
ef1b09a
to
7c3f281
Compare
…b.com/Semantic-Org/Semantic-UI-React into tests/shorthand-strict # Conflicts: # test/specs/commonTests/implementsShorthandProp.js
|
@levithomason I've changed an option name 👍 |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
Extracted from #1795.
containsis too strict, we should allow non-strict assert in these cases, useless conditions should gone.