-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Dropdown): implement selectOnNavigation
prop
#2009
feat(Dropdown): implement selectOnNavigation
prop
#2009
Conversation
Great, next steps here will be adding an example to the docs in Then, we also need a test for this in |
Codecov Report
@@ Coverage Diff @@
## master #2009 +/- ##
=========================================
+ Coverage 99.8% 99.8% +<.01%
=========================================
Files 148 148
Lines 2561 2590 +29
=========================================
+ Hits 2556 2585 +29
Misses 5 5
Continue to review full report at Codecov.
|
Cool, thanks much! We'll get a review on this as soon as we can. I just made a release so we'll target next weekend for releasing this one. |
Just to let you know: I was not able to test the Doc example. |
If you mean automated tests, that's OK. Doc example tests are a little looser than they should be right now. We just render them and assert no errors occurred. This is done automatically for you. |
No, I meant I was unable to open the docs locally after building, to see if/how the example looked and worked. The tests should be passing. |
selectOnKeydown
prop (#1993)selectOnKeydown
prop
Fixed lint issues, testing manually. Hope to ship this one today as well! |
Ok, finished updating docs. I renamed this prop to I added test assertions and doc descriptions to clarify the prop controls the change in value. The fact that |
selectOnKeydown
propselectOnNavigation
prop
Released in |
No description provided.