breaking(Checkbox): callback with new checked value in onClick #2014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change onClick's checked value to be the new representation of the checked state instead of the representation before the event was triggered BREAKING CHANGE: Checkbox.onClick has changed how the checked property is defined. To migrate update code that references checked property to the opposite value currently assumed. Closes Semantic-Org#1936
Codecov Report
@@ Coverage Diff @@
## master #2014 +/- ##
=========================================
+ Coverage 99.76% 99.8% +0.04%
=========================================
Files 148 148
Lines 2556 2589 +33
=========================================
+ Hits 2550 2584 +34
+ Misses 6 5 -1
Continue to review full report at Codecov.
|
layershifter
approved these changes
Aug 29, 2017
levithomason
changed the title
|
Thanks again! |
|
Released in |
layershifter
pushed a commit
that referenced
this pull request
Sep 11, 2017
breaking(Checkbox): callback with new checked value in onClick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking Change
Currently, it represented the previous checked state the
checkedvalue in a Checkbox'sonClickcallback represents the old state. It now represents the newcheckedstate.Before
You needed to negate the
checkedvalue to get the correct new value:After
The
checkedvalue represents the correct new value.change onClick's checked value to be the new representation of the
checked state instead of the representation before the event was
triggered
BREAKING CHANGE: Checkbox.onClick has changed how the checked property
is defined. To migrate update code that references checked property to
the opposite value currently assumed.
Closes #1936