Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(Visibility): use RAF #2019

Merged
merged 2 commits into from
Sep 11, 2017
Merged

perf(Visibility): use RAF #2019

merged 2 commits into from
Sep 11, 2017

Conversation

layershifter
Copy link
Member

Visibility now uses requestAnimationFrame for scroll listener.

@codecov-io
Copy link

codecov-io commented Aug 29, 2017 •
edited

Codecov Report

Merging #2019 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2019      +/-   ##
==========================================
+ Coverage   99.76%   99.76%   +<.01%     
==========================================
  Files         148      148              
  Lines        2561     2565       +4     
==========================================
+ Hits         2555     2559       +4     
  Misses          6        6
Impacted Files Coverage Δ
src/behaviors/Visibility/Visibility.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7f39631...26f77cd. Read the comment docs.

Merge branch 'master' of https://github.com/Semantic-Org/Semantic-UI-…
26f77cd 
…React into perf/visibility-raf

# Conflicts:
#	src/behaviors/Visibility/Visibility.js
#	test/specs/behaviors/Visibility/Visibility-test.js
layershifter
layershifter commented Sep 2, 2017
View reviewed changes
Copy link
Member Author

@layershifter layershifter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@levithomason I solved merge conflicts

@levithomason levithomason merged commit a70a675 into master Sep 11, 2017
@levithomason levithomason deleted the perf/visibity-raf branch September 11, 2017 03:36
@levithomason
Copy link
Member

Released in semantic-ui-react@0.73.0

layershifter added a commit that referenced this pull request Sep 11, 2017
@layershifter
perf(Visibility): use RAF (#2019)
64a4f31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
optimization ready for merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@layershifter @codecov-io @levithomason