Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(mixed): renamed unsafe lifecycle methods #3747

Merged
merged 3 commits into from Aug 16, 2019

Conversation

@jmyrland
Copy link
Contributor

jmyrland commented Aug 15, 2019

Executed via npx react-codemod rename-unsafe-lifecycles --parser babel
Disabled lint issues for updated lines.

The changes should mitigate the "Unsafe lifecycle" warnings.

Closes #3741
Related to #2732

Executed via `npx react-codemod rename-unsafe-lifecycles --parser babel`
Disabled lint issues for updated lines.

Closes #3741
Related to #2732
@welcome

This comment has been minimized.

Copy link

welcome bot commented Aug 15, 2019

💖 Thanks for opening this pull request! 💖

Here is a list of things that will help get it across the finish line:

  • Run yarn lint locally to catch formatting errors. This will fix some errors automatically, commit and push any changes.
  • Run yarn test locally to catch errors. This ensures all components still behave as they should.
  • Run yarn start to run the doc site locally and try a few pages, ensuring everything is in good working order.
  • Include tests when adding/changing behavior.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Aug 15, 2019

Codecov Report

Merging #3747 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3747   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files         175      175           
  Lines        3125     3125           
=======================================
  Hits         3120     3120           
  Misses          5        5
Impacted Files Coverage Δ
src/modules/Transition/TransitionGroup.js 100% <ø> (ø) ⬆️
src/modules/Sticky/Sticky.js 99.09% <ø> (ø) ⬆️
...ddons/TransitionablePortal/TransitionablePortal.js 100% <ø> (ø) ⬆️
src/modules/Transition/Transition.js 100% <ø> (ø) ⬆️
src/behaviors/Visibility/Visibility.js 100% <ø> (ø) ⬆️
src/modules/Dropdown/Dropdown.js 100% <100%> (ø) ⬆️
src/modules/Search/Search.js 99.54% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9bcc76a...e403626. Read the comment docs.

@jmyrland

This comment has been minimized.

Copy link
Contributor Author

jmyrland commented Aug 16, 2019

Additional info: only the src folder has been affected by this change.

Also, most of the files were skipped (asuming they did not need a change).

@layershifter

This comment has been minimized.

Copy link
Member

layershifter commented Aug 16, 2019

@jmyrland thank you for taking this ❤️

I updated PR with react package bump to ensure that we don't have any issues, but CI failed on two tests. Trying to understand why 🤔

@jmyrland

This comment has been minimized.

Copy link
Contributor Author

jmyrland commented Aug 16, 2019

Nice @layershifter 👍 Kudos for all the effort in making condributions "newb-friendly" 😁 Really easy to get up and running with the project & ready to contribute 👌

As for the failing tests - I'm not sure whats causing this, but I see you "fixed" it by disabling some of the tests.

Let me know if you need anything else from my end 👍

@layershifter

This comment has been minimized.

Copy link
Member

layershifter commented Aug 16, 2019

Nice @layershifter 👍 Kudos for all the effort in making condributions "newb-friendly" 😁 Really easy to get up and running with the project & ready to contribute 👌

😍

As for the failing tests - I'm not sure whats causing this, but I see you "fixed" it by disabling some of the tests.

Yea, I don't have any idea why they fails

@layershifter layershifter merged commit dd66e92 into Semantic-Org:master Aug 16, 2019
3 checks passed
3 checks passed
ci/circleci Your tests passed on CircleCI!
Details
codecov/patch 100% of diff hit (target 99.84%)
Details
codecov/project 99.84% (+0%) compared to 9bcc76a
Details
@welcome

This comment has been minimized.

Copy link

welcome bot commented Aug 16, 2019

Congrats on merging your first pull request! 🎉🎉🎉

robot victory dance

@jmyrland jmyrland deleted the jmyrland:fb-rename-unsafe-lifecycle branch Aug 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.