fix(Image): pass loading attribute to an img element
#4116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a newer standardized attribute that doesn't work if placed on a wrapping element.
Codecov Report
@@ Coverage Diff @@
## master #4116 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 180 180
Lines 3241 3241
=======================================
Hits 3233 3233
Misses 8 8 Continue to review full report at Codecov.
|
layershifter
changed the title
loading prop/attribute through to the img elementloading attribute to an img element
|
Thanks for fixing this ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/img#attr-loading (it's part of the WHATWG spec now, not just experimental)
This allows use of the attribute when the image uses a wrapping element, e.g:
<Image loading="lazy" wrapped />Currently it gets set on the wrapper
divwhich is useless.