Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Button): handle type properly #4321

Merged
merged 2 commits into from
Jan 19, 2022
Merged

fix(Button): handle type properly #4321

merged 2 commits into from
Jan 19, 2022

Conversation

layershifter
Copy link
Member

Fixes #4318.

When Button has label we pass a limited set of props to the inner button, this PR adds type to this set.

@github-actions
Copy link

github-actions bot commented Jan 19, 2022 •
edited
Loading

size-limit report

Path Size
bundle-size/dist/Button.size.js 58.76 KB (+0.05% 🔺)
bundle-size/dist/Icon.size.js 25.21 KB (0%)
bundle-size/dist/Image.size.js 53.91 KB (0%)
bundle-size/dist/Modal.size.js 68.9 KB (+0.05% 🔺)
bundle-size/dist/Portal.size.js 40.61 KB (0%)

@layershifter layershifter merged commit 21be1b6 into master Jan 19, 2022
@layershifter layershifter deleted the fix/button-type branch January 19, 2022 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
PR: Bug Fix 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can't set type="button" when using Button with a label.
1 participant
@layershifter