Deprecated: Array and string offset access syntax with curly braces is deprecated

[kghbln]

Setup and configuration

• SMW version: 3.2.3
• SCI version: 2.1.1
• MW version: 1.35.4
• DB (MySQL etc. and version): 8.0.15

Issue

When rebuilding data I get the following notices:

Deprecated: Array and string offset access syntax with curly braces is deprecated in /../w/extensions/SemanticCite/src/Bibtex/BibtexParser.php on line 99

Deprecated: Array and string offset access syntax with curly braces is deprecated in /../w/extensions/SemanticCite/src/Bibtex/BibtexParser.php on line 111

Deprecated: Array and string offset access syntax with curly braces is deprecated in /../w/extensions/SemanticCite/src/Bibtex/BibtexParser.php on line 140

Deprecated: Array and string offset access syntax with curly braces is deprecated in /../w/extensions/SemanticCite/src/Bibtex/BibtexParser.php on line 143

Deprecated: Array and string offset access syntax with curly braces is deprecated in /../w/extensions/SemanticCite/src/PreTextFormatter.php on line 36

Deprecated: Array and string offset access syntax with curly braces is deprecated in /../w/extensions/SemanticCite/src/PreTextFormatter.php on line 40

[bescheid]

Setup (just newly installed)

MW 1.35.5,
SMW 3.2.3,
SCI: 2.1.1.
PHP: 8.0.17

Issue

Pages which use {{#scite: ...}} do not show up. Instead I get:
"Fatal error: Array and string offset access syntax with curly braces is no longer supported in /var/www/html/r3/extensions/SemanticCite/src/Bibtex/BibtexParser.php on line 99"

[bescheid]

After manually changing the respective curly braces indicated in kghbin's post, into [$] everthing works fine.

[krabina]

Maybe we did not fully understand the issue here. The #scite parser function now certainly is working again. Also i do not get any error messages on running rebuildData.php

[pinfold]

I just ran into this issue. Can you clarify when you say "After manually changing the respective curly braces indicated in kghbin's post, into [$] everthing works fine." can you give an example? Did you change

{{#scite:Byrne 2008
|type=journal
|author=Byrne, A
|date=2008
|title=Web 2.0 strategies in libraries and information services
|journal=The Australian Library Journal
|volume=57
|number=4
|pages=365-376
|file=Web 2 0 strategy in libraries and information services.pdf
}}

to

[$scite:Byrne 2008
|type=journal
|author=Byrne, A
|date=2008
|title=Web 2.0 strategies in libraries and information services
|journal=The Australian Library Journal
|volume=57
|number=4
|pages=365-376
|file=Web 2 0 strategy in libraries and information services.pdf
]

[krabina]

No, this will definitely not work. The curyl braces deprecation is related to the source code, not the wikitext (parser function) that you use. So it seems that @bescheid has manually corrected things in the source code, but we did not get a pull request, so we don't have this yet.

[krabina]

It seems this is wrong:

SemanticCite/src/Bibtex/BibtexParser.php

Lines 99 to 101 in 67ecb1b

	if( $rev[0] != ',') {
	$content .= ',';
	}

see https://phabricator.wikimedia.org/T231303