Skip to content
This repository has been archived by the owner on Mar 25, 2019. It is now read-only.

Don't hardcode property names! #5

Closed
mwjames opened this issue Feb 10, 2018 · 2 comments
Closed

Don't hardcode property names! #5

mwjames opened this issue Feb 10, 2018 · 2 comments
Labels
bug Something isn't working

Comments

@mwjames
Copy link

mwjames commented Feb 10, 2018

Things like array($comNS . ":" . $pageName, "?Has comment date"), shouldn't be found in a class, this isn't a user input!

$qandp = SMWQueryProcessor::getQueryAndParamsFromFunctionParams(
array($comNS . ":" . $pageName, "?Has comment date"),
SMW_OUTPUT_WIKI, INLINE_QUERY, true
);
$queryResult = explode( "|", SMWQueryProcessor::getResultFromQuery(
$qandp[0], $qandp[1],
SMW_OUTPUT_WIKI, INLINE_QUERY )
);

@kghbln
Copy link
Member

kghbln commented Feb 10, 2018

Related to #1. Currently this extension does not support I18n at all.

@kghbln kghbln added the bug Something isn't working label Feb 10, 2018
@PeterTheOne PeterTheOne mentioned this issue Feb 13, 2018
7 tasks
@kghbln
Copy link
Member

kghbln commented Mar 25, 2019

This extension was abandoned. See #25 for further details and an alternative.

@kghbln kghbln closed this as completed Mar 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants