New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SemanticDataLookup, use `DISTINCT` for non subject items, refs 2928, 3531 #3617

Merged
merged 1 commit into from Jan 13, 2019

Conversation

Projects
None yet
2 participants
@mwjames
Copy link
Contributor

mwjames commented Jan 13, 2019

This PR is made in reference to: #2928, #3531

This PR addresses or contains:

  • #2928 caused a regression with the case described in #3531

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Fixes #3531

@mwjames mwjames merged commit 9bc0e8f into master Jan 13, 2019

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@mwjames mwjames deleted the issue-3531 branch Jan 13, 2019

kghbln added a commit that referenced this pull request Jan 18, 2019

@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented Jan 18, 2019

Back-ported with 9152f94

@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented Jan 19, 2019

Back-ported with 9152f94

I guess some of the previous tidies need to be backported too or this backport reverted. Not sure if this needs to be in 3.0.x

@mwjames

This comment has been minimized.

Copy link
Contributor Author

mwjames commented Jan 19, 2019

I guess some of the previous tidies need to be backported too or this backport reverted.

Should be #3585.

@kghbln

This comment has been minimized.

Copy link
Member

kghbln commented Jan 19, 2019

Should be #3585.

Thanks for the pointer. Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment