Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SemanticDataLookup, use DISTINCT for non subject items, refs 2928, 3531 #3617

Merged
merged 1 commit into from
Jan 13, 2019

Conversation

mwjames
Copy link
Contributor

@mwjames mwjames commented Jan 13, 2019

This PR is made in reference to: #2928, #3531

This PR addresses or contains:

This PR includes:

  • Tests (unit/integration)
  • CI build passed

Fixes #3531

@kghbln
Copy link
Member

kghbln commented Jan 18, 2019

Back-ported with 9152f94

@kghbln
Copy link
Member

kghbln commented Jan 19, 2019

Back-ported with 9152f94

I guess some of the previous tidies need to be backported too or this backport reverted. Not sure if this needs to be in 3.0.x

@mwjames
Copy link
Contributor Author

mwjames commented Jan 19, 2019

I guess some of the previous tidies need to be backported too or this backport reverted.

Should be #3585.

@kghbln
Copy link
Member

kghbln commented Jan 19, 2019

Should be #3585.

Thanks for the pointer. Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants