Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port conflict between heimdall and zigbee2mqtt_assistant (8880) #751

Closed
nfelger opened this issue Feb 13, 2024 · 1 comment · Fixed by #752
Closed

Port conflict between heimdall and zigbee2mqtt_assistant (8880) #751

nfelger opened this issue Feb 13, 2024 · 1 comment · Fixed by #752

Comments

@nfelger
Copy link

nfelger commented Feb 13, 2024

Both containers seem to want to use port 8880. I'm new to IOTStack, so maybe I missed an option to configure ports (but I thought they should be conflict-free out-of-the-box).

Can we change one of them? Or is there another way I can fix this?

  heimdall:
    image: ghcr.io/linuxserver/heimdall
    container_name: heimdall
    environment:
    - PUID=1000
    - PGID=1000
    - TZ=Etc/UTC
    volumes:
    - ./volumes/heimdall/config:/config
    ports: 
    - 8880:80
    - 8883:443
    restart: unless-stopped
  ...
  zigbee2mqtt_assistant:
    container_name: zigbee2mqtt_assistant
    image: carldebilly/zigbee2mqttassistant
    restart: unless-stopped
    ports:
    - "8880:80"
    environment:
    - VIRTUAL_HOST=~^zigbee2mqtt_assistant\..*\.xip\.io
    - Z2MA_SETTINGS__MQTTSERVER=mosquitto
    - VIRTUAL_PORT=8880
@Paraphraser
Copy link

I recommend using 8882 for Heimdall. I'll put in a PR to change this (unless you want to submit the PR yourself). This is just one of those things that will happen from time to time because it's easy to forget to do the check when proposing a new container.

Paraphraser added a commit to Paraphraser/IOTstack that referenced this issue Feb 14, 2024
Issue SensorsIot#751 reports external port 8880 is used for both Heimdall and
Zigbee2MQTT_Assistant. This PR changes the port to 8882:

```
$ git -C ~/IOTstack/.templates grep 8880
heimdall/service.yml:    - 8880:80
zigbee2mqtt_assistant/service.yml:    - "8880:80"
zigbee2mqtt_assistant/service.yml:    - VIRTUAL_PORT=8880
$ git -C ~/IOTstack/.templates grep 8882
$
```

Using port 8882 for HTTP also conveniently aligns with the second
Heimdall port-mapping of `8883:443`.

Also takes the opportunity to adopt up-to-date syntax for `TZ=`.

Fixes SensorsIot#751

Signed-off-by: Phill Kelley <34226495+Paraphraser@users.noreply.github.com>
Paraphraser added a commit to Paraphraser/IOTstack that referenced this issue Feb 14, 2024
Issue SensorsIot#751 reports external port 8880 is used for both Heimdall and
Zigbee2MQTT_Assistant. This PR changes the port to 8882:

```
$ git -C ~/IOTstack/.templates grep 8880
heimdall/service.yml:    - 8880:80
zigbee2mqtt_assistant/service.yml:    - "8880:80"
zigbee2mqtt_assistant/service.yml:    - VIRTUAL_PORT=8880
$ git -C ~/IOTstack/.templates grep 8882
$
```

Using port 8882 for HTTP also conveniently aligns with the second
Heimdall mapping of `8883:443`.

Old-menu documentation reduced to a stub pointing to the Wiki.

Signed-off-by: Phill Kelley <34226495+Paraphraser@users.noreply.github.com>
@Slyke Slyke closed this as completed in #752 Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants