2024-02-14 Heimdall port conflict - master branch - PR 1 of 2 #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue SensorsIot#751 reports external port 8880 is used for both Heimdall and Zigbee2MQTT_Assistant. This PR changes the port to 8882: ``` $ git -C ~/IOTstack/.templates grep 8880 heimdall/service.yml: - 8880:80 zigbee2mqtt_assistant/service.yml: - "8880:80" zigbee2mqtt_assistant/service.yml: - VIRTUAL_PORT=8880 $ git -C ~/IOTstack/.templates grep 8882 $ ``` Using port 8882 for HTTP also conveniently aligns with the second Heimdall port-mapping of `8883:443`. Also takes the opportunity to adopt up-to-date syntax for `TZ=`. Fixes SensorsIot#751 Signed-off-by: Phill Kelley <34226495+Paraphraser@users.noreply.github.com>
Slyke
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #751 reports external port 8880 is used for both Heimdall and Zigbee2MQTT_Assistant. This PR changes the port to 8882:
Using port 8882 for HTTP also conveniently aligns with the second Heimdall port-mapping of
8883:443.Also takes the opportunity to adopt up-to-date syntax for
TZ=.Fixes #751