Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dupe bundles #146

Merged
merged 7 commits into from Jul 2, 2020
Merged

Dupe bundles #146

merged 7 commits into from Jul 2, 2020

Conversation

jamesstout
Copy link
Contributor

What does this implement/fix? Explain your changes.

Prevents duplicated bundle menu items.

Does this close any currently open issues?

#119

Any other comments?

Please test

Where has this been tested?

Devices/Simulators: iMac

macOS Version: 10.15.5

Sequel-Ace Version: 2.1.1

@Jason-Morcos
Copy link
Member

Working for me! I conflicted it up though trying to fix my mistake of adding more default bundles and not setting the isDefaultBundle key. Hopefully you can just pull back dev and it's good!

@Jason-Morcos Jason-Morcos merged commit dcc525e into Sequel-Ace:dev Jul 2, 2020
@jamesstout
Copy link
Contributor Author

Tested again in dev. Looks good with your changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants