-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Quote Command Is Broken #356
Labels
Comments
Sigh... there is still something wrong here, it works on my reproduction, but not in the bot. I guess it's something to do with the bots permission to the serenity fork?
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In summary, it looks like somehow commit 37f927c actually broke the bot more, than fixing anything.
@IdanHo Noticed that this is probably because of the implementation of
valueToTreeObject
in theoctokit-plugin-create-pull-request
package, where they check if it's a string, and if it isn't they give up parsing it and send the contents to the github blobs API instead.https://github.com/gr2m/octokit-plugin-create-pull-request/blob/682ea7b47c16ce2b13bc07b09d201ea30381770b/src/value-to-tree-object.ts#L28
Link to the conversation on Discord
Chat Logs from discussing issue...
Logs from a failed quote invocation...
The text was updated successfully, but these errors were encountered: