Fix the quote command #527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accessing GitHub APIs for PR creation can easily exceed 3s. After that, the interaction ID is gone if we don't defer the reply.
That way, they can more easily see whether they have been quoted, which is nice for giving consent.
kleinesfilmroellchen
force-pushed
the
quote-fix
branch
from
e7bfc1b
to
136390d
Compare
|
I don't think this fixes the encoding/github issues that #356 describes. Happy to merge these fixes as they look good, I just don't see how it addresses that specific bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That has been broken for a while, the reason comes down to Discord interaction restrictions.
Also a small fix to include quoted username in created PRs, which I find more transparent.
Fixes #356