LibJS+LibWeb: Implement WebAssembly Native Errors

[networkException]

This pull request adds the CompileError, RuntimeError and LinkError native errors and exposes them on the WebAssembly object.

Initially I tried defining the errors outside LibJS, this however is non trivial as both we and the spec rely (?) on intrinsics knowing about them.

[linusg]

There's no reason whatsoever for these errors to live in LibJS. In fact, if anything that doesn't have a spec on tc39.es needs to exist in LibJS, that's an architectural issue we need to solve. (console excluded, and there's one HTML spec data member somewhere and that's already annoying)

Here's the spec you'll want to look at and implement in LibWeb: https://webassembly.github.io/spec/js-api/#error-objects

[networkException]

Ah I wasn't aware of the strict spec isolation (but it makes a whole lot of sense obviously). Sadly I don't really know where to begin with changing the architecture to support non LibJS native errors.

[alimpfard]

You can look at how the various DOMExceptions are currently implemented, these basically follow the same concept.

looks like they're just PlatformObjects now: https://github.com/SerenityOS/serenity/blob/master/Userland/Libraries/LibWeb/DOM/DOMException.h

[linusg]

These are different though and explicitly not platform objects, only things defined via WebIDL are.

They implement the NativeError object structure from ES, as described in the spec I linked. You might be able to use the existing DECLARE_NATIVE_ERROR macros for this.

[networkException]

Right, I tried using DECLARE_NATIVE_ERROR{,_CONSTRUCTOR,_PROTOTYPE} initially.

However implementing ConstructorName::construct requires ordinary_create_from_constructor which isn't really designed to take host specific prototypes:

• The spec defines "Assert: intrinsicDefaultProto is this specification's name of an intrinsic object" as a step and

• we require a member of Intrinsics to be passed.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

[AtkinsSJ]

This has conflicts.

[stale]

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions!

[stale]

This pull request has been closed because it has not had recent activity. Feel free to re-open if you wish to still contribute these changes. Thank you for your contributions!