LibWeb: Resolve percentage vertical-align values against line-height #18084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
linusg
suggested changes
Mar 29, 2023
linusg
added
⏳ pr-waiting-for-author
...instead of not resolving them at all. :^)
awesomekling
force-pushed
the
css-percentage-vertical-align
branch
from
61972f6
to
07e604b
Compare
Aarp, that's what I get for thinking "hey this doesn't need SerenitySans, as it doesn't have text". But of course the default line-height is still derived from the font 😅 |
github-actions
bot
added
👀 pr-needs-review
linusg
approved these changes
Mar 29, 2023
linusg
added
✅ pr-maintainer-approved-but-awaiting-ci
github-actions
bot
removed
the
✅ pr-maintainer-approved-but-awaiting-ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...instead of not resolving them at all. :^)