TextEditor: Prevent autoscroll looping over #18781
Conversation
github-actions
bot
added
the
👀 pr-needs-review
| if (position.y() <= 0) { | ||
| column_index = 0; | ||
| line_index = 0; | ||
| return IterationDecision::Break; | ||
| } |
There was a problem hiding this comment.
i see it works but it still makes me wonder; iʼd guess iʼd go for y ≤ 0 yielding line → 0 and if y < 0 then additionally column → 0… 🤔
There was a problem hiding this comment.
I don't quite understand why this happens, but once y is -1, -2... column gets set to line length.
There was a problem hiding this comment.
maybe we should not rely on that to avoid mistakes when this mysterious logic changes? 🤔
but thatʼs on you (and maintainers). 😄
When a text file has only 1 line with long text autoscroll to the top will no longer loop over and set the cursor to the end of the line.
AhmedTheGeek
force-pushed
the
texteditor_scroll_loop
branch
from
644a46d
to
2d81d1d
Compare
| @@ -181,7 +181,7 @@ TextPosition TextEditor::text_position_at_content_position(Gfx::IntPoint content | |||
| switch (m_text_alignment) { | |||
| case Gfx::TextAlignment::CenterLeft: | |||
| for_each_visual_line(line_index, [&](Gfx::IntRect const& rect, auto& view, size_t start_of_line, [[maybe_unused]] bool is_last_visual_line) { | |||
| if (is_multi_line() && !rect.contains_vertically(position.y()) && !is_last_visual_line) | |||
| if (is_multi_line() && !rect.contains_vertically(position.y()) && !is_last_visual_line && position.y() >= 0) | |||
There was a problem hiding this comment.
@konradekk I believe this was the reason the column index kept resetting to the line length after y got to values less than 0. We needed to keep our IterationDecision set to continue only if position.y value is greater than or equal to 0.
When that condition wasn't there it just kept repeating the loop forever.
github-actions
bot
removed
the
👀 pr-needs-review
When a text file has only 1 line with long text auto-scroll to the top will no longer loop over and set the cursor to the end of the line.
Before the fix:
Screencast.from.2023-05-12.14-09-59.webm
After:
Screencast.from.2023-05-12.14-10-44.webm