LibGfx: Add a .pam loader #22935
Merged
LibGfx: Add a .pam loader #22935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
|
I just realized, can we have a test? 😃 |
.pam is a "portrable arbitrarymap" as documented at https://netpbm.sourceforge.net/doc/pam.html It's very similar to .pbm, .pgm, and .ppm, so this uses the PortableImageMapLoader framework. The header is slightly different, so this has a custom header parsing function. Also, .pam only exixts in binary form, so the ascii form support becomes optional.
These are written by `mutool extract` for CMYK images. They don't contain color profiles so they're not super convenient. But `image` can convert them (*) to sRGB as long as you use it with `--assign-color-profile` pointing to some CMYK icc profile of your choice. *: Once SerenityOS#22922 is merged.
Hand-written in a text editor. I verified that `convert` converts it to a png that looks like the test expectations.
Hand-written in a text editor. I verified that `convert` converts it to a png that looks like the rgb test expectations.
|
Sure, added tests. I couldn't find a prebuilt binary of https://netpbm.sourceforge.net/doc/pamtopng.html in |
LucasChollet
added
✅ pr-community-approved
github-actions
bot
removed
the
✅ pr-community-approved
nico
added a commit
to nico/serenity
that referenced
this pull request
Jan 26, 2024
This is already done at the caller decode() in PortableImageLoaderCommon.h, as pointed out by @LucasChollet at SerenityOS#22935 (comment) No behavior change.
awesomekling
pushed a commit
that referenced
this pull request
Jan 26, 2024
This is already done at the caller decode() in PortableImageLoaderCommon.h, as pointed out by @LucasChollet at #22935 (comment) No behavior change.
kleinesfilmroellchen
pushed a commit
to kleinesfilmroellchen/serenity
that referenced
this pull request
Jan 27, 2024
This is already done at the caller decode() in PortableImageLoaderCommon.h, as pointed out by @LucasChollet at SerenityOS#22935 (comment) No behavior change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.pam is a "portrable arbitrarymap" as documented at
https://netpbm.sourceforge.net/doc/pam.html
It's very similar to .pbm, .pgm, and .ppm, so this uses the
PortableImageMapLoader framework. The header is slightly different,
so this has a custom header parsing function.
Also, .pam only exixts in binary form, so the ascii form support
becomes optional.
This doesn't yet implement the BLACKANDWHITE DEFINED TUPLE TYPE from https://netpbm.sourceforge.net/doc/pam.html since the spec isn't super clear on what that means.
It does add support for the CMYK tuple type which isn't documented on that page, but which
mutool extractwrites for CMYK images in PDFs. See #22922 (comment) for an example.