LibWeb: Fire input event on user interaction with input element buttons #24347
+47
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
trflynn89
reviewed
May 17, 2024
tcl3
force-pushed
the
libweb_fire_inputevent_on_step_button_click
branch
2 times, most recently
from
38ea1ac
to
68660f2
Compare
trflynn89
reviewed
May 20, 2024
|
It looks like we aren't always firing change events when we should be. I think it would be a good idea to tackle that as part of this PR. |
github-actions
bot
removed
the
👀 pr-needs-review
Input elements without a defined user-interaction behavior need to fire an input event when the user changes the element's value in some way. This change moves the code to do this into its own function and adds some spec text to explain what is being done.
An input event is now fired when the step up or step down button of an input element of type number is clicked. This ensures that any associated <output> element is updated when these buttons are clicked.
This matches the behavior of other browsers. Previously, a click event was used, so the value was only updated when the mouse was released.
This matches the behavior of other browsers.
tcl3
force-pushed
the
libweb_fire_inputevent_on_step_button_click
branch
from
68660f2
to
3b1d83a
Compare
github-actions
bot
added
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An input event is now fired when the step up or step down button of an input element of type number is clicked.
This ensures that any associated
<output>element is updated when these buttons are clicked.Demo:
input_element_step_buttons.mp4