-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LibWeb: Fire input event on user interaction with input element buttons #24347
LibWeb: Fire input event on user interaction with input element buttons #24347
Conversation
38ea1ac
to
68660f2
Compare
It looks like we aren't always firing change events when we should be. I think it would be a good idea to tackle that as part of this PR. |
Input elements without a defined user-interaction behavior need to fire an input event when the user changes the element's value in some way. This change moves the code to do this into its own function and adds some spec text to explain what is being done.
An input event is now fired when the step up or step down button of an input element of type number is clicked. This ensures that any associated <output> element is updated when these buttons are clicked.
This matches the behavior of other browsers. Previously, a click event was used, so the value was only updated when the mouse was released.
This matches the behavior of other browsers.
68660f2
to
3b1d83a
Compare
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions! |
This pull request has been closed because it has not had recent activity. Feel free to re-open if you wish to still contribute these changes. Thank you for your contributions! |
An input event is now fired when the step up or step down button of an input element of type number is clicked.
This ensures that any associated
<output>
element is updated when these buttons are clicked.Demo:
input_element_step_buttons.mp4