Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LibWeb: Fire input event on user interaction with input element buttons #24347

Closed
wants to merge 4 commits into from
Closed

LibWeb: Fire input event on user interaction with input element buttons #24347

wants to merge 4 commits into from

Commits on May 22, 2024

  1. LibWeb: Deduplicate the firing of input events in HTMLInputElement 

    Input elements without a defined user-interaction behavior need to fire
an input event when the user changes the element's value in some way.
This change moves the code to do this into its own function and adds
some spec text to explain what is being done.
    @tcl3
    tcl3 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    ccd3a19 View commit details
    Browse the repository at this point in the history

  2. LibWeb: Fire input event on user interaction with input element buttons 

    An input event is now fired when the step up or step down button of an
input element of type number is clicked.

This ensures that any associated <output> element is updated when these
buttons are clicked.
    @tcl3
    tcl3 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    d737a6c View commit details
    Browse the repository at this point in the history

  3. LibWeb: Update number input on mousedown of number input buttons 

    This matches the behavior of other browsers. Previously, a click event
was used, so the value was only updated when the mouse was released.
    @tcl3
    tcl3 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    c6ed79d View commit details
    Browse the repository at this point in the history

  4. LibWeb: Fire a change event on mouseup of number input buttons 

    This matches the behavior of other browsers.
    @tcl3
    tcl3 committed May 22, 2024
    Configuration menu
    Copy the full SHA
    3b1d83a View commit details
    Browse the repository at this point in the history