LibGfx/GIF: Support loop_count and duration #24412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
👀 pr-needs-review
LucasChollet
force-pushed
the
gif_animation_loop
branch
from
beea9ad
to
dc17458
Compare
nico
approved these changes
May 22, 2024
nico
added
✅ pr-community-approved
trflynn89
reviewed
May 22, 2024
This allows us to encode the required number of loops in the file.
This allows us to write the duration of each frame.
This was working with files, but with pre-allocated buffers, the end is not the same position as last written byte.
LucasChollet
force-pushed
the
gif_animation_loop
branch
from
dc17458
to
a48f223
Compare
github-actions
bot
added
👀 pr-needs-review
github-actions
bot
removed
the
👀 pr-needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.