Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LibGfx/GIF: Correctly write frames with a non-null position #24416

Merged
merged 1 commit into from
May 25, 2024

Conversation

LucasChollet
Copy link
Member

Fix #24411

@github-actions github-actions bot added the 👀 pr-needs-review PR needs review from a maintainer or community member label May 22, 2024
Copy link
Contributor

@nico nico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe tweak the animation test to hit this case (see webp animation test for an example).

@LucasChollet
Copy link
Member Author

Sure, you'll have to wait until tomorrow for that tho

@LucasChollet
Copy link
Member Author

LucasChollet commented May 24, 2024

see webp animation test for an example

This was the worst advice you could give me. I copied some parts of it, including this line, which has a behavior that isn't really intuitive:
rgb_bitmap_2->scanline(3)[3] = Color::Red;
(hint: type of the lhs is ARGB aka int)

Fun fact: for some reason that I don't understand, the WebP test fails if you write a color with an alpha value equal to 255, but pass otherwise. I'll let you fix this one. See #24428

@nico
Copy link
Contributor

nico commented May 24, 2024

#24433

@AtkinsSJ AtkinsSJ merged commit fb79aa6 into SerenityOS:master May 25, 2024
11 checks passed
@github-actions github-actions bot removed the 👀 pr-needs-review PR needs review from a maintainer or community member label May 25, 2024
@LucasChollet LucasChollet deleted the gif_at branch May 25, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gif encoder creates broken outputs
3 participants