LibWasm: Improve spec test generation #24502
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
👀 pr-needs-review
|
Closing in favor of LadybirdBrowser/ladybird#41 in the main Ladybird repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All types of spec tests should be properly generated now. This PR might actually decrease the percentage of passed spectests because it enables more of them :(. Draft PR for now because SIMD tests aren't being generated yet. Also, there are a few spec tests that the new script uncovers that crash the VM. What should I do about those for now? Should I fix those crashes in this PR, or just leave it like that? The spec tests don't get to finish running if the VM crashes.