AK: Make some tweaks to AK::Span. #3166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This assertion was added to prevent accitentally using stuff like Span<int*> instead of Span<int>. But there can be spans of pointers.
I originally defined the bytes() method for the String class, because it made it obvious that it's a span of bytes instead of span of characters. This commit makes this more consistent by defining a bytes() method when the type of the span is known to be u8. Additionaly, the cast operator to Bytes is overloaded for ByteBuffer and such.
nico
reviewed
Aug 15, 2020
nico
reviewed
Aug 16, 2020
awesomekling
pushed a commit
that referenced
this pull request
Aug 16, 2020
awesomekling
pushed a commit
that referenced
this pull request
Aug 16, 2020
This was a careless mistake. #3166 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains a few minor tweaks,
renames the
span()methods on containers tobytes()if it is known at compile time that bytes are contained, andadds some utility functions like
Span::copy_to()orSpan::fill()that are abstracting formemcpy(),memmove()andmemset().