Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LibCore+LibGUI: add StandardPaths::documents_directory and add Documents and Downloads directories to tray shortcuts in FilePicker #6268

Closed
wants to merge 4 commits into from
Closed

LibCore+LibGUI: add StandardPaths::documents_directory and add Documents and Downloads directories to tray shortcuts in FilePicker #6268

wants to merge 4 commits into from

Conversation

ZikiFlicky
Copy link
Contributor

No description provided.

awesomekling
awesomekling requested changes Apr 12, 2021
View reviewed changes
Copy link
Collaborator

@awesomekling awesomekling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not used by anything? Please don't add dead code. Instead, add this in a PR that uses it for something.

@ZikiFlicky
Copy link
Contributor Author

I was planning to add a Documents shortcut in the left toolbar in the FilePicker widget that will use the method, but I wasn't sure if it belongs in this pull request. Sorry for not mentioning it 😬

@ZikiFlicky
Copy link
Contributor Author

I added Documents and Downloads folders to FilePicker. can you review the changes?

@ZikiFlicky ZikiFlicky changed the title LibCore: add StandardPaths::documents_directory LibCore+LibGUI: add StandardPaths::documents_directory and use it for FilePicker Apr 13, 2021
@ZikiFlicky ZikiFlicky changed the title LibCore+LibGUI: add StandardPaths::documents_directory and use it for FilePicker LibCore+LibGUI: add StandardPaths::documents_directory and add Documents and Downloads directories to tray shortcuts in FilePicker Apr 13, 2021
@ZikiFlicky ZikiFlicky closed this Apr 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dexesttp Dexesttp Dexesttp left review comments

@awesomekling awesomekling awesomekling requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ZikiFlicky @Dexesttp @awesomekling