Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with dtors not being called + add more tests #11

Merged
merged 1 commit into from
Feb 5, 2024

Conversation

SergeyMakeev
Copy link
Owner

  1. Fix the issue with value's destructors not being called sometimes
  2. Add more tests to catch similar issues in the future

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7d001e9) 100.00% compared to head (371e9eb) 100.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #11   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines         1250      1336   +86     
=========================================
+ Hits          1250      1336   +86     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SergeyMakeev SergeyMakeev merged commit 711382a into main Feb 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants