Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

align TmsTree: catch type T = type defs as new TmsTypeDef TmsStatement #5

Open
SerhiyShamshetdinov opened this issue Jul 26, 2021 · 0 comments
Open

align TmsTree: catch type T = type defs as new TmsTypeDef TmsStatement #5

SerhiyShamshetdinov opened this issue Jul 26, 2021 · 0 comments
Labels
tech debt Technical debt

Comments

@SerhiyShamshetdinov
Copy link
Owner

SerhiyShamshetdinov commented Jul 26, 2021 •
edited
Loading

Scope
TmsTree

What may be better or simplified?
TmsTree will be smoother when type defs are TmsTypeDef TmsStatement node (not in TmsOtherTree like now), this removes isDef checks from TmsOtherTree

Describe the solution

  • create type defs as new TmsStatement TmsTypeDef and add all transformation levels to it
  • clean TmsOtherTree checks with tree.isDef (including conditional untypecheching while lifting)
  • etc. ?

Tests
should pass without changes
@SerhiyShamshetdinov SerhiyShamshetdinov added the tech debt Technical debt label Jul 26, 2021
@SerhiyShamshetdinov SerhiyShamshetdinov changed the title align TmsTree: catch type T = type defs as new TmsTypeDef TmsStatement align TmsTree: catch type T = type defs as new TmsTypeDef TmsStatement Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
tech debt Technical debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@SerhiyShamshetdinov