Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace explicit type with <> #446

Closed
wants to merge 1 commit into from
Closed

Conversation

linyy1991
Copy link
Contributor

@linyy1991 linyy1991 commented Dec 19, 2017

Follow this checklist to help us incorporate your contribution quickly and easily:

  • Make sure there is a JIRA issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
  • Each commit in the pull request should have a meaningful subject line and body.
  • Format the pull request title like [JAV-XXX] Fixes bug in ApproximateQuantiles, where you replace JAV-XXX with the appropriate JIRA issue.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Run mvn clean install to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

fix #445

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 86.723% when pulling 4782655 on linyy1991:yy into f206a8b on ServiceComb:master.

@WillemJiang WillemJiang self-requested a review December 19, 2017 10:36
@WillemJiang
Copy link
Member

Merged the patch into master branch by resolving the conflicting files by hand with thanks to linyy1991.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicit type can be replaced with <>
4 participants