Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize versionrule.go #126

Merged
merged 33 commits into from
Oct 20, 2017
Merged

Optimize versionrule.go #126

merged 33 commits into from
Oct 20, 2017

Conversation

little-cui
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Oct 18, 2017

Codecov Report

Merging #126 into master will increase coverage by 0.19%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
+ Coverage    67.2%   67.39%   +0.19%     
==========================================
  Files          18       18              
  Lines        4184     4190       +6     
==========================================
+ Hits         2812     2824      +12     
+ Misses       1195     1192       -3     
+ Partials      177      174       -3
Impacted Files Coverage Δ
server/service/util/versionrule.go 100% <100%> (ø) ⬆️
server/service/instances.go 67.03% <100%> (+0.18%) ⬆️
server/service/services_dependency.go 68.3% <0%> (+0.7%) ⬆️
server/service/governservice.go 65.53% <0%> (+1.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 160520a...8c46163. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 71.159% when pulling 70418c7 on little-cui:master into fa2904b on ServiceComb:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.1%) to 71.751% when pulling 8c46163 on little-cui:master into 160520a on ServiceComb:master.

@little-cui little-cui merged commit 8ddf198 into apache:master Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants