Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Save config in cache when starting the app and when modifying config #349

Merged
merged 9 commits into from
Jan 17, 2023

Conversation

gabegma
Copy link
Contributor

@gabegma gabegma commented Dec 23, 2022

Resolve #345

Description:

  • I took the opportunity to do some refactoring so we can skip the validation tasks and start-up tasks in some cases. For now, this is only useful in the update_config route, in the except condition.
  • This refactoring triggered some new mypy warnings that I have fixed.

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

azimuth/app.py Outdated Show resolved Hide resolved
azimuth/app.py Outdated Show resolved Hide resolved
Co-authored-by: Joseph Marinier <joseph.marinier@servicenow.com>
Copy link
Contributor

@JosephMarinier JosephMarinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool! That paves the way for a lot of cool features. 👍

@gabegma gabegma enabled auto-merge (squash) January 17, 2023 22:16
@gabegma gabegma merged commit bfa253a into main Jan 17, 2023
@gabegma gabegma deleted the ggm/save_cache_files branch January 17, 2023 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Save config files in caching folder with json lines
2 participants