-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Exclude fields from cache #350
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick review, but I need to look into more details the exclude function so I can understand it :)
Thank you for all your help on this!
077140d
to
90eebfd
Compare
so we can deal with `Union`s.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work with this PR!! Thank you for taking my relay on this. I could not have brought it this far.
Of course! Thank you! I enjoyed this one and I learn a bunch about pydantic. 👍 |
Resolve #348
Description:
Exclude desired fields from cache hash by setting an extra parameter
exclude_from_cache=True
. This allows for more granular control over which config fields (when they are edited) will trigger some modules to recompute. For example, we don't need to recompute the predictions if a pipeline's name changes, so we addexclude_from_cache=True
to thename
field.Checklist:
You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.
ran
pre-commit run --all-files
at the end.our users.
README
files and our wiki for any big design decisions, if relevant.