Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new start-up tasks #332

Merged
merged 5 commits into from
Jan 5, 2023
Merged

Add new start-up tasks #332

merged 5 commits into from
Jan 5, 2023

Conversation

gabegma
Copy link
Contributor

@gabegma gabegma commented Dec 8, 2022

Description:

On big datasets, the behavioral testing summary and class overlap modules would error out in the UI, while they were being computed. I added them both to the start-up, and that forced me to refactor so we could define what dataset splits to send to a particular start-up task.

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

@gabegma gabegma marked this pull request as draft December 8, 2022 04:41
@gabegma
Copy link
Contributor Author

gabegma commented Dec 23, 2022

I'm waiting on the changes in #350, about including datasets in the hash before removing this from draft.

azimuth/app.py Outdated Show resolved Hide resolved
@gabegma gabegma marked this pull request as ready for review January 3, 2023 20:39
azimuth/startup.py Outdated Show resolved Hide resolved
Copy link
Contributor

@JosephMarinier JosephMarinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect we will end up not using those lines, but just in case, some small details...

azimuth/startup.py Outdated Show resolved Hide resolved
azimuth/startup.py Outdated Show resolved Hide resolved
azimuth/startup.py Outdated Show resolved Hide resolved
azimuth/startup.py Outdated Show resolved Hide resolved
Copy link
Contributor

@JosephMarinier JosephMarinier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! And thank you, I learned a bunch of things. 👍

Co-authored-by: Joseph Marinier <joseph.marinier@servicenow.com>
@gabegma gabegma enabled auto-merge (squash) January 5, 2023 04:54
@gabegma gabegma disabled auto-merge January 5, 2023 04:54
@gabegma gabegma enabled auto-merge (squash) January 5, 2023 15:10
@gabegma gabegma merged commit cadd235 into main Jan 5, 2023
@gabegma gabegma deleted the ggm/add-start-up-tasks branch January 5, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants