-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new start-up tasks #332
Conversation
I'm waiting on the changes in #350, about including datasets in the hash before removing this from draft. |
55e7940
to
d190aa7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect we will end up not using those lines, but just in case, some small details...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job! And thank you, I learned a bunch of things. 👍
Co-authored-by: Joseph Marinier <joseph.marinier@servicenow.com>
Description:
On big datasets, the behavioral testing summary and class overlap modules would error out in the UI, while they were being computed. I added them both to the start-up, and that forced me to refactor so we could define what dataset splits to send to a particular start-up task.
Checklist:
You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.
ran
pre-commit run --all-files
at the end.our users.
README
files and our wiki for any big design decisions, if relevant.