Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix front-end tests #468

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Fix front-end tests #468

merged 1 commit into from
Feb 27, 2023

Conversation

JosephMarinier
Copy link
Contributor

Description:

The problem was caused by #420 and #466 having incompatible changes (but yet no conflicts).

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

The problem was caused by #420 and #466 having incompatible changes (but yet no conflicts).
Copy link
Contributor

@nandhinibsn nandhinibsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for taking care of this fix 👍

@JosephMarinier JosephMarinier merged commit a92d7dc into main Feb 27, 2023
@JosephMarinier JosephMarinier deleted the joseph/fix-front-end-tests branch February 27, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants