Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove /admin route prefix #466

Merged
merged 4 commits into from
Feb 24, 2023
Merged

Conversation

JosephMarinier
Copy link
Contributor

Description:

  • Remove /admin route prefix in front of config routes. It didn't make much sense since getting the config is not really an "admin" action. In fact, the front end gets the config throughout the app.
  • Fix duplicated front end cache tag

Checklist:

You should check all boxes before the PR is ready. If a box does not apply, check it to acknowledge it.

  • ISSUE NUMBER. You linked the issue number (Ex: Resolve #XXX).
  • PRE-COMMIT. You ran pre-commit on all commits, or else, you
    ran pre-commit run --all-files at the end.
  • USER CHANGES. The changes are added to CHANGELOG.md and the documentation, if they impact
    our users.
  • DEV CHANGES.
    • Update the documentation if this PR changes how to develop/launch on the app.
    • Update the README files and our wiki for any big design decisions, if relevant.
    • Add unit tests, docstrings, typing and comments for complex sections.

in front of config routes. It didn't make much sense since getting the config is not really an "admin" action. In fact, the front end gets the config throughout the app.
Copy link
Contributor

@gabegma gabegma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it. While you are here - in test_routers, could you remove the annoying admin folder and rename the test file to test_config?

@JosephMarinier JosephMarinier marked this pull request as draft February 24, 2023 21:25
@JosephMarinier
Copy link
Contributor Author

Totally! Good catch!

@JosephMarinier JosephMarinier marked this pull request as ready for review February 24, 2023 21:30
@JosephMarinier JosephMarinier enabled auto-merge (squash) February 24, 2023 21:32
@JosephMarinier JosephMarinier merged commit 9233a51 into main Feb 24, 2023
@JosephMarinier JosephMarinier deleted the joseph/remove-admin-route-prefix branch February 24, 2023 21:55
JosephMarinier added a commit that referenced this pull request Feb 25, 2023
The problem was caused by #420 and #466 having incompatible changes (but yet no conflicts).
@JosephMarinier JosephMarinier mentioned this pull request Feb 25, 2023
4 tasks
JosephMarinier added a commit that referenced this pull request Feb 27, 2023
The problem was caused by #420 and #466 having incompatible changes (but yet no conflicts).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants