Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More comprehensive unit testing #381

Open
sampreet-arthi opened this issue Oct 10, 2020 · 0 comments
Open

More comprehensive unit testing #381

sampreet-arthi opened this issue Oct 10, 2020 · 0 comments
Labels
CI/CD enhancement New feature or request good first issue Good for newcomers
Milestone

Comments

@sampreet-arthi
Copy link
Member

There seem to be some vulnerabilities in our code that might fail easily. I suggest adding more unit tests for the following:

  • Custom agents (there's only VPG and PPO on CartPole-v0 as of now. We should preferably add more to cover discrete-offpolicy, continuous-offpolicy and continuous-onpolicy)
  • Evaluation for the Bandits and Classical agents
  • Testing of convergence of agents as proposed in Training Agents in CI #312
  • Buffers
  • VecEnv (no test for parallel vec envs)
  • Unit tests for all the ongoing projects (Model-based, Distributed, Offline, Evolutionary and MARL)

Not a priority at the moment but will have to do before the next release.

@sampreet-arthi sampreet-arthi added enhancement New feature or request good first issue Good for newcomers CI/CD labels Oct 10, 2020
@sampreet-arthi sampreet-arthi added this to the v0.0.3 milestone Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant