Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrectly vertically padded buttons in settings #519

Closed
bhajneet opened this issue May 13, 2020 · 1 comment · Fixed by #588
Closed

Incorrectly vertically padded buttons in settings #519

bhajneet opened this issue May 13, 2020 · 1 comment · Fixed by #588
Assignees
@saihaj
Labels
Impacts Few Does not affect many end-users. ○ Type Bug Regressions/production issues that do not function as intended.

Comments

@bhajneet
Copy link
Member

image

The buttons have less space at the red lines than they do between each other or settings toggles have between themselves
@bhajneet bhajneet added Status: On Hold ○ Type Bug Regressions/production issues that do not function as intended. Impacts Few Does not affect many end-users. labels May 13, 2020
@bhajneet bhajneet mentioned this issue Jul 5, 2020
Closed
@saihaj saihaj self-assigned this Jul 6, 2020
@saihaj
Copy link
Member

saihaj commented Jul 8, 2020

I don't think that bottom one is different because it the last item adds padding exactly the same as other options have. Learn more button's padding definitely has issues and that will be fixed.
image

saihaj added a commit to saihaj/ShabadOSpresenter that referenced this issue Jul 8, 2020
@saihaj
fix: vertically paddings of buttons in settings
04d4839 
Fixes shabados#519
@saihaj saihaj mentioned this issue Jul 8, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@saihaj saihaj

Labels
Impacts Few Does not affect many end-users. ○ Type Bug Regressions/production issues that do not function as intended.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: vertical paddings of buttons in settings saihaj/ShabadOSpresenter
2 participants
@bhajneet @saihaj