SPFx Commandset title not changing

[maliksahil]

Thank you for reporting an issue or suggesting an enhancement. We appreciate your feedback - to help the team to understand your needs, please complete the below template to ensure we have the necessary details to assist you.

Category

• Question
• [x ] Bug
• Enhancement

Expected or Desired Behavior

I'm using node 6.12, npm 3.10, and SPFx 1.4 on a Modern site.
I generate a commandset extension (new project), deploy - everything works as expected.
Now, I want to change the logic .. I want to show change the title of "COMMAND_1" to reflect the number of rows selected.

I change my onListViewUpdated as follows,

public onListViewUpdated(event: IListViewCommandSetListViewUpdatedParameters): void {
const compareOneCommand: Command = this.tryGetCommand('COMMAND_1');
if (compareOneCommand) {
// This command should be hidden unless exactly one row is selected.
compareOneCommand.visible = event.selectedRows.length > 0;
console.log(event.selectedRows.length);
compareOneCommand.title = "Selected " + event.selectedRows.length;
}
}

Now I go about selecting rows - but even though in debug mode event.selectedRows.length shows me the correct value, and compareOneCommand.title shows the proper value, the in UX, the title always says "Selected 0".

Expected: Selected x .. where x is number of rows selected.

Observed Behavior

The title always says "Selected 0" which is incorrect.

Steps to Reproduce

As above ..

Thanks for your contribution! Sharing is scaring.

[paulwillen]

Just a notice that this is still an issue - Is there a ETA for a fix for this?

[digbar]

Hey guys.

Trying to make this work.
I am using v1.4.1 for SP19.
I guess if it where it was probably for the latest versions.
Is that correct @andrewconnell?

[tripleseven73]

Ran into this issue today. It seems as if the HTML for a Command is generated once and then shown/hidden depending on the .visible property?

In #6245 @andrewconnell states that "Dynamically switching the title is not supported". However the documentation of the Command class title property suggests it should be possible and as an example even describes a scenario that is, for all intents and purposes, the same as the one described by @maliksahil.

Any ETA for a solution?

[andrewconnell]

It's my understanding that you can't change the title of a command set button/link. The reason why is because it's defined in the manifest for the component where you can also localize the title.

Microsoft needs to confirm that, but that's my undersatnding.

[Katli95]

If so, then the docs are out of date or at least incorrect, in the ones mentioned by @tripleseven73 they say:

Altering the title property is intended to allow minor changes to the title, e.g. “Submit these 3 items” or toggling between “Schedule” and “Unschedule”...

I also feel like this used to work, and was included in some demos from Microsoft, but I don't have the links to back it up.

[andrewconnell]

I double-checked with the SPFx engineering team and the docs are correct; the title property should respect changes from the API. They're investigating and if there's an update to provide, they'll chime in.

[Katli95]

Has there been any update on this? It seems insignificant but having the ability to change "selected document" to "selected documents" is actually quite valuable to UX 😇 (Even more so for languages with greater changes in singular v. plural)

[hamedy]

sent a proposal to a customer that requires this feature and I'm stuck now. I'm implementing adding/removing documents to personal favourites and I need the ability to change the command title. Appreciate it if you provide a ETA for a fix.

[mayo589]

Hi, we are waiting for this fix too, the ability to dynamically set title of our commands is crucial for us :)

[patmill]

The title can be changed on execute (as of a month ago), but not on listview updated. The latter is tracked by #7375

[ghost]

Issues that have been closed & had no follow-up activity for at least 7 days are automatically locked. Please refer to our wiki for more details, including how to remediate this action if you feel this was done prematurely or in error: Issue List: Our approach to locked issues