Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuickLaunch navigation (for SinglePageWebParts) fails #5227

Closed
1 task done
ng-marcus opened this issue Jan 27, 2020 · 11 comments
Closed
1 task done

QuickLaunch navigation (for SinglePageWebParts) fails #5227

ng-marcus opened this issue Jan 27, 2020 · 11 comments
Labels
area:spfx Category: SharePoint Framework (not extensions related) status:fixed-next-drop Issue planned to be fixed in an upcoming release.
Milestone

Comments

@ng-marcus
Copy link

Category

  • Bug

Describe the bug

On some tenancies, we are seeing clicks on the left hand menu (QuickLaunch) being ignored unless the link is clicked twice. This is quite similar to an error we had some months ago #3168 When the link is clicked, the URL updates but the original content is rendered. We're not seeing our React didMount or render functions getting called.

Steps to reproduce

Add a page and set it to SinglePageWebPart. Add an SPFX component.
Create another page
Click the first page - its content will render
Click the second page - the URL changes but the content remains the same
Click either link twice and it forces a reload and the full content is there.

Adding another page without seeing it to SinglePageWebPart - navigation between the two page types works as expected.

Expected behavior

Page content to update

Developer environment

SPFX 1.09 and 1.10 have the same issue

@msft-github-bot
Copy link
Collaborator

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@msft-github-bot msft-github-bot added the Needs: Triage 🔍 Awaiting categorization and initial review. label Jan 27, 2020
@ng-marcus ng-marcus changed the title QuickLaunch navigation (for SinglePageWebParts) QuickLaunch navigation (for SinglePageWebParts) fails Jan 27, 2020
@andrewconnell andrewconnell added area:other Category: unknown (does not fit any other category) area:spfx Category: SharePoint Framework (not extensions related) status:to-be-reviewed Issue needs to be reviewed by Microsoft for additional follow up / review. type:bug-suspected Suspected bug (not working as designed/expected). See “type:bug-confirmed” for confirmed bugs. and removed Needs: Triage 🔍 Awaiting categorization and initial review. labels Jan 27, 2020
@andrewconnell
Copy link
Collaborator

@GrahamMcMynn Is this related to the navigation events?

@ng-marcus
Copy link
Author

ng-marcus commented Jan 27, 2020

(I think you can ignore this double call, as this happens on tenancies where it still works)

This may be related (and I only looked because this was the issue last time) but when the page loads, it makes two calls to get the page json . (the page is Contacts.aspx here)

image

Both are GET calls

The second response has no response body.

@GrahamMcMynn
Copy link

@andrewconnell - I don't believe it is, however, I will take a look and try reproducing it.

@ng-marcus
Copy link
Author

If it would help with analysis if you would like access to our Dev tenancy let me know and I can create a user account for you.

@patmill
Copy link
Contributor

patmill commented Nov 9, 2021

Sorry for going dark @ng-marcus . We have made a series of fixes on the page->page navigation flows over the past while. Is this still an issue for you?

@patmill patmill added the Needs: Author Feedback Awaiting response from the original poster of the issue. Marked as stale if no activity for 7 days. label Nov 9, 2021
@ng-marcus
Copy link
Author

Hi @patmill Thanks for checking in. I'll get the team to test and get back to you tomorrow. We added a work around that fully loaded the page each time, so we will disable that and see how it works now.

@ghost ghost added Needs: Attention 👋 Original poster responded to request for feedback, awaiting attention from Microsoft / community. and removed Needs: Author Feedback Awaiting response from the original poster of the issue. Marked as stale if no activity for 7 days. labels Nov 9, 2021
@ng-marcus
Copy link
Author

Hi @patmill We still see the same problem sorry. With Single Page Apps we still have the issue where the user has to click twice on a navigation link to make the content change.

@patmill
Copy link
Contributor

patmill commented Nov 10, 2021

Thanks @ng-marcus - we're looking into this.

@patmill patmill added status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. and removed type:bug-suspected Suspected bug (not working as designed/expected). See “type:bug-confirmed” for confirmed bugs. status:to-be-reviewed Issue needs to be reviewed by Microsoft for additional follow up / review. Needs: Attention 👋 Original poster responded to request for feedback, awaiting attention from Microsoft / community. area:other Category: unknown (does not fit any other category) labels Nov 10, 2021
@AJIXuMuK AJIXuMuK added status:fixed-next-drop Issue planned to be fixed in an upcoming release. and removed status:working-on-it Known issue / feature being addressed. Will use other "status:*" labels & comments for more detail. labels Nov 11, 2021
@AJIXuMuK AJIXuMuK added this to the 11-11 milestone Nov 11, 2021
@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Dec 1, 2021

This should be WW now.

@AJIXuMuK AJIXuMuK closed this as completed Dec 1, 2021
@ghost
Copy link

ghost commented Dec 9, 2021

Issues that have been closed & had no follow-up activity for at least 7 days are automatically locked. Please refer to our wiki for more details, including how to remediate this action if you feel this was done prematurely or in error: Issue List: Our approach to locked issues

@ghost ghost locked as resolved and limited conversation to collaborators Dec 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area:spfx Category: SharePoint Framework (not extensions related) status:fixed-next-drop Issue planned to be fixed in an upcoming release.
Projects
None yet
Development

No branches or pull requests

6 participants