-
Notifications
You must be signed in to change notification settings - Fork 998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pageContext does not refresh in app customizers on inline navigation #6253
Comments
Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible. |
We have noticed this too. Could this be a general problem with url-query parameters when using inline navigation? |
There are indeed issues with partial page transitions, check the following posts for a couple of techniques to overcome this: https://www.eliostruyf.com/things-to-check-in-your-spfx-application-customizer-after-page-transitions/ |
@estruyf - Thanks for your answer.. Actually we are allready using the same techniques you mentioned in your blog post to workaround this issues (like navigatedEvents, navigation history). If nothing works, pageContext somehow did not refresh, the only thing we can do (like in your code) is to trigger a full page reload. (not based on a language check, in our case, listId, listTitle and a lot more are empty) The big difference is, that this actually happens if a user navigates between a modern page and a doc lib and not like in your code, only when the user navigates between different hubs or site collections. Means: the overall inline navigation concept between pages and libs can not be used and always needs a full page reload in order to provide the correct pageContext. |
BTW, the double placeholders #4945 was already reported a long time ago. Issue is still open. |
Can confirm that we are also experiencing this issue. We are making use of an ApplicationExtension to run some code on all pages, which is now only running on full page loads/reloads. @estruyf Will explore the options in your article, thanks for that. |
We are experiencing this as well. Thank you @estruyf for pointing out this link that has provided a good work around for me: https://blog.velingeorgiev.com/page-hit-when-SPA-page-transitioning-modern-sharepoint-sites |
This is definitely still an issue for me and according to my logs, it started happening more and more starting in May for me. I see this happen across tenants thousands of times per week. I've used some of the workarounds but it's not guaranteed. |
Sorry @netti01 for the long delay. |
This should be WW now. |
Issues that have been closed & had no follow-up activity for at least 7 days are automatically locked. Please refer to our wiki for more details, including how to remediate this action if you feel this was done prematurely or in error: Issue List: Our approach to locked issues |
Category
[x ] Question
Question
We assume that based on inline navigation between modern pages and lists/libs, that there is a possible issue with refreshing the page context. This is likely not only a problem with SPFX, perhaps more a general logic bug in SPO itself ?!
This has been tested using the following app customizer template from github:
https://github.com/estruyf/appcustomizer-navigation-issues-spfx
We extended the information the app customizer delivers within the header section with additional properties like "pageItemId, listTitle..."
When a user does an inline navigation between a modern UI page and e.g. the SitePages library, the header displays empty properties, even if you use the standard refresh events in SPFX like:
this.context.application.navigatedEvent
This is the default output if you directly load a doc lib.
![image](https://user-images.githubusercontent.com/44964962/92568555-a0c11c00-f27f-11ea-8c1c-2b075d41fb23.png)
This is the output if you do an inline navigation from a page to the lib
![image](https://user-images.githubusercontent.com/44964962/92568693-d534d800-f27f-11ea-9e24-9b300d042830.png)
As you can see, also the url of the lib is incorrect.
We also figured out that inline navigation to doc libs/lists causes some additional issues which may be related to this behavior, like:
Any help or tipps on how to address this issues to the right people? We allready opened support tickets for these issues on our tenant, still at first level support, and it is not easy to explain the direct user impact because the app customizer is somehow "custom development".
Thanks
Bjoern
Environment details
Tags
#spfx-tooling #spfx
Possible related issues
#6237
The text was updated successfully, but these errors were encountered: