Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 SPFx v1.15 - gulp clean doesn't remove the 'releases' folder #8263

Closed
1 of 9 tasks
andrewconnell opened this issue Jul 2, 2022 · 4 comments
Closed
1 of 9 tasks
Assignees
Labels
area:spfx Category: SharePoint Framework (not extensions related) status:fixed-next-drop Issue planned to be fixed in an upcoming release. type:bug-suspected Suspected bug (not working as designed/expected). See “type:bug-confirmed” for confirmed bugs.
Milestone

Comments

@andrewconnell
Copy link
Collaborator

Target SharePoint environment

SharePoint Online

What SharePoint development model, framework, SDK or API is this about?

💥 SharePoint Framework

Developer environment

macOS

What browser(s) / client(s) have you tested

  • 💥 Internet Explorer
  • 💥 Microsoft Edge
  • 💥 Google Chrome
  • 💥 FireFox
  • 💥 Safari
  • mobile (iOS/iPadOS)
  • mobile (Android)
  • not applicable
  • other (enter in the "Additional environment details" area below)

Additional environment details

  • SPFx v1.15
  • Node.js v16

Describe the bug / error

The task gulp clean removes all temp folders generated by a built, except the releases folder. The releases folder is missing in the configuration for the task within the @microsoft/gulp-core-build package, specifically in the task's file ./@microsoft/gulp-core-build/lib/tasks/CleanTask.js ,lines 27 & 28:

const { distFolder, libFolder, libAMDFolder, tempFolder } = this.buildConfig;
let cleanPaths = [distFolder, libFolder, tempFolder];

If the task clean is supposed to clean up files that shouldn't committed to source control, the releases folder should also be removed.

Steps to reproduce

  1. Create SPFx project with any type of component
  2. Wait for npm install to complete
  3. Build project once: gulp build
  4. Clean project: gulp clean
  5. Observe releases still present

Expected behavior

Releases isn't present after running gulp clean

@andrewconnell andrewconnell added the type:bug-suspected Suspected bug (not working as designed/expected). See “type:bug-confirmed” for confirmed bugs. label Jul 2, 2022
@ghost
Copy link

ghost commented Jul 2, 2022

Thank you for reporting this issue. We will be triaging your incoming issue as soon as possible.

@ghost ghost added the Needs: Triage 🔍 Awaiting categorization and initial review. label Jul 2, 2022
@VesaJuvonen VesaJuvonen added area:spfx Category: SharePoint Framework (not extensions related) and removed Needs: Triage 🔍 Awaiting categorization and initial review. labels Jul 4, 2022
@AJIXuMuK AJIXuMuK self-assigned this Jul 5, 2022
@AJIXuMuK AJIXuMuK added this to the 1.15.0-next milestone Jul 5, 2022
@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Jul 5, 2022

Thanks @andrewconnell for reporting this one.
The fix has been done and will be included in the next release.

@AJIXuMuK AJIXuMuK added the status:fixed-next-drop Issue planned to be fixed in an upcoming release. label Jul 6, 2022
@AJIXuMuK
Copy link
Collaborator

AJIXuMuK commented Aug 2, 2022

1.15.2 is out - this should be fixed

@AJIXuMuK AJIXuMuK closed this as completed Aug 2, 2022
@ghost
Copy link

ghost commented Aug 9, 2022

Issues that have been closed & had no follow-up activity for at least 7 days are automatically locked. Please refer to our wiki for more details, including how to remediate this action if you feel this was done prematurely or in error: Issue List: Our approach to locked issues

@ghost ghost locked as resolved and limited conversation to collaborators Aug 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area:spfx Category: SharePoint Framework (not extensions related) status:fixed-next-drop Issue planned to be fixed in an upcoming release. type:bug-suspected Suspected bug (not working as designed/expected). See “type:bug-confirmed” for confirmed bugs.
Projects
None yet
Development

No branches or pull requests

3 participants