New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Office-ui-fabric-react version with drop 1.2 #827

Closed
wobba opened this Issue Sep 1, 2017 · 5 comments

Comments

Projects
None yet
4 participants
@wobba
Contributor

wobba commented Sep 1, 2017

Category

  • Question

The SPFx docs says to take an explicit dependency on office-ui-fabric-react v2.x. Drop v1.2 comes with v4.32.0 after running the yeoman generator.

Does that mean for drop v1.2 we should take a dependency on v4.x?

@wobba

This comment has been minimized.

Show comment
Hide comment
@wobba

wobba Sep 4, 2017

Contributor

Also, if you take a dependency on 2.x with drop 1.2, it won't build.

Contributor

wobba commented Sep 4, 2017

Also, if you take a dependency on 2.x with drop 1.2, it won't build.

@DennisKuhn

This comment has been minimized.

Show comment
Hide comment
@DennisKuhn

DennisKuhn Sep 4, 2017

I think the docs are behind. Drop v1.2 works fine for me with office-ui-react 4.32. As it is the new package version, I would update my dependencies to that. I updated my project with npm and it went sweet. I created a new "HelloWorld" with yo @microsoft/sharepoint to compare dependencies and stuff.

DennisKuhn commented Sep 4, 2017

I think the docs are behind. Drop v1.2 works fine for me with office-ui-react 4.32. As it is the new package version, I would update my dependencies to that. I updated my project with npm and it went sweet. I created a new "HelloWorld" with yo @microsoft/sharepoint to compare dependencies and stuff.

@wobba

This comment has been minimized.

Show comment
Hide comment
@wobba

wobba Sep 4, 2017

Contributor

I can make it work as well, but it's important to keep docs up to date with drops, especially when static linking is recommended together with adding an explicit version of UI fabric. Ideally I would like the old way, where I didn't have to bundle in UI fabric as it was pre-loaded with SPFx.

Contributor

wobba commented Sep 4, 2017

I can make it work as well, but it's important to keep docs up to date with drops, especially when static linking is recommended together with adding an explicit version of UI fabric. Ideally I would like the old way, where I didn't have to bundle in UI fabric as it was pre-loaded with SPFx.

@mcmynn83

This comment has been minimized.

Show comment
Hide comment
@mcmynn83

mcmynn83 commented Sep 6, 2017

@spdevdocs

This comment has been minimized.

Show comment
Hide comment
@spdevdocs

spdevdocs Apr 29, 2018

Contributor

We closed this issue as it had not activity within last 180 days. This is a generic process we have decided to perform for issues, which have not been explicitly marked still to be "work in progress" based on tags. We are performing this cleaning to make sure that old issues that have already been solved (but not closed) or are no longer relevant are cleaned out and make the issues more manageable. If this issue still valid, we would ask you to open a new issue and follow the guidance in the issue template related on the recommended location. We do apologize any inconveniences this might cause. Please do remember that issues in the issue lists are also messages for others in the community, so you can also check if you can assist on any of them. “Sharing is caring!”

Contributor

spdevdocs commented Apr 29, 2018

We closed this issue as it had not activity within last 180 days. This is a generic process we have decided to perform for issues, which have not been explicitly marked still to be "work in progress" based on tags. We are performing this cleaning to make sure that old issues that have already been solved (but not closed) or are no longer relevant are cleaned out and make the issues more manageable. If this issue still valid, we would ask you to open a new issue and follow the guidance in the issue template related on the recommended location. We do apologize any inconveniences this might cause. Please do remember that issues in the issue lists are also messages for others in the community, so you can also check if you can assist on any of them. “Sharing is caring!”

@spdevdocs spdevdocs closed this Apr 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment