New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peoplepicker - Remove Messagebar error handling and use normal div and textmessage #140

Closed
AsishP opened this Issue Sep 21, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@AsishP
Contributor

AsishP commented Sep 21, 2018

Category

[X] Enhancement

[ ] Bug

[ ] Question

Version

Please specify what version of the library you are using: [ 1.7.0 ]

Expected / Desired Behavior / Question

Required Message in People Picker is taking too much space when implemented on a form. Need consistency with Office Fabric UI error message handling

Observed Behavior

Modify the error message handling of the control to use Office Fabri UI error message format so to keep it consitent with other controls. Basically remove message bar and use normal div elements.

Please provide any further suggestions from the above

Thanks!

@AsishP AsishP changed the title from Peoplepicker - Remove Messagebar error handling and use Office Fabric UI format (Enhancement) to Peoplepicker - Remove Messagebar error handling and use normal div and textmessage (Enhancement) Sep 22, 2018

@AsishP AsishP changed the title from Peoplepicker - Remove Messagebar error handling and use normal div and textmessage (Enhancement) to Peoplepicker - Remove Messagebar error handling and use normal div and textmessage (change) Sep 22, 2018

@AsishP AsishP changed the title from Peoplepicker - Remove Messagebar error handling and use normal div and textmessage (change) to Peoplepicker - Remove Messagebar error handling and use normal div and textmessage Sep 22, 2018

@AsishP

This comment has been minimized.

Contributor

AsishP commented Sep 22, 2018

@estruyf, have submitted this PR.

@estruyf

This comment has been minimized.

Collaborator

estruyf commented Oct 26, 2018

The PR is merged and will be available in the latest beta version. Follow this guide in order to test out a beta version: https://sharepoint.github.io/sp-dev-fx-controls-react/beta/

@estruyf

This comment has been minimized.

Collaborator

estruyf commented Nov 6, 2018

This is now available in version 1.10.0.

@estruyf estruyf closed this Nov 6, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment