Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peoplepicker - Remove Messagebar error handling and use normal div and textmessage #140

Closed
AsishP opened this issue Sep 21, 2018 · 3 comments
Closed

Peoplepicker - Remove Messagebar error handling and use normal div and textmessage #140

AsishP opened this issue Sep 21, 2018 · 3 comments
Milestone
1.10.0

Comments

@AsishP
Copy link
Contributor

AsishP commented Sep 21, 2018

Category

[X] Enhancement

[ ] Bug

[ ] Question

Version

Please specify what version of the library you are using: [ 1.7.0 ]

Expected / Desired Behavior / Question

Required Message in People Picker is taking too much space when implemented on a form. Need consistency with Office Fabric UI error message handling

Observed Behavior

Modify the error message handling of the control to use Office Fabri UI error message format so to keep it consitent with other controls. Basically remove message bar and use normal div elements.

Please provide any further suggestions from the above

Thanks!
@AsishP AsishP changed the title Peoplepicker - Remove Messagebar error handling and use Office Fabric UI format (Enhancement) Peoplepicker - Remove Messagebar error handling and use normal div and textmessage (Enhancement) Sep 22, 2018
@AsishP AsishP changed the title Peoplepicker - Remove Messagebar error handling and use normal div and textmessage (Enhancement) Peoplepicker - Remove Messagebar error handling and use normal div and textmessage (change) Sep 22, 2018
@AsishP AsishP changed the title Peoplepicker - Remove Messagebar error handling and use normal div and textmessage (change) Peoplepicker - Remove Messagebar error handling and use normal div and textmessage Sep 22, 2018
@AsishP AsishP mentioned this issue Sep 22, 2018
Closed
@AsishP
Copy link
Contributor Author

AsishP commented Sep 22, 2018

@estruyf, have submitted this PR.

@AsishP AsishP mentioned this issue Oct 16, 2018
Merged
@estruyf estruyf added this to the 1.10.0 milestone Oct 26, 2018
@estruyf
Copy link
Member

estruyf commented Oct 26, 2018

The PR is merged and will be available in the latest beta version. Follow this guide in order to test out a beta version: https://sharepoint.github.io/sp-dev-fx-controls-react/beta/

@estruyf estruyf mentioned this issue Nov 5, 2018
Merged
@estruyf
Copy link
Member

estruyf commented Nov 6, 2018

This is now available in version 1.10.0.

@estruyf estruyf closed this as completed Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.10.0
Development

No branches or pull requests
2 participants
@estruyf @AsishP