Prevent the user to create a folder with null or an empty string
#1095
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 34b9598): https://sharezone-test--pr1095-prevent-to-empty-tex-nfup9v89.web.app (expires Sat, 14 Oct 2023 12:54:02 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 4cb3ae61e1e018abfd9841fd3239f5b49ccc034b |
nilsreichardt
added
the
build-app-preview
|
⬇️ Generated builds by Codemagic for commit 34b9598 ⬇️ Note: Only Sharezone team members are able to install the iOS app.
|
Jonas-Sander
approved these changes
Sep 26, 2023
| /// If [isNullOrEmptyTextAllowed] is `false` and the user submits `null` or an | ||
| /// empty text, then the dialog will not be closed and the [onTap] callback | ||
| /// will not be called. Instead an error message will be shown. | ||
| final bool isNullOrEmptyTextAllowed; |
There was a problem hiding this comment.
Suggested change
| final bool isNullOrEmptyTextAllowed; | |
| final bool isEmptyAllowed; |
I think that this should be still clear but a bit more readable. WDYT?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Before this PR, you could create a folder with an empty string or click the create button when a text field had the value
nullwhich caused a null operator exception. This PR fixes the issue by checking if the text isnullor empty.Demo